Skip to content

Added test case for commit ref with percent encoding #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2019
Merged

Added test case for commit ref with percent encoding #1118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd99151
Added test case for commit ref with percent encoding
vaibhavsingh97 Feb 20, 2019
11d4853
Improved structure of code
vaibhavsingh97 Feb 23, 2019
6d09900
Improved structure of code
vaibhavsingh97 Feb 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions github/repos_commits_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,45 @@ func TestRepositoriesService_GetCommitSHA1(t *testing.T) {
}
}

func TestRepositoriesService_NonAlphabetCharacter_GetCommitSHA1(t *testing.T) {
client, mux, _, teardown := setup()
defer teardown()
const sha1 = "01234abcde"

mux.HandleFunc("/repos/o/r/commits/master%20hash", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeV3SHA)

fmt.Fprintf(w, sha1)
})

got, _, err := client.Repositories.GetCommitSHA1(context.Background(), "o", "r", "master%20hash", "")
if err != nil {
t.Errorf("Repositories.GetCommitSHA1 returned error: %v", err)
}

if want := sha1; got != want {
t.Errorf("Repositories.GetCommitSHA1 = %v, want %v", got, want)
}

mux.HandleFunc("/repos/o/r/commits/tag", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeV3SHA)
testHeader(t, r, "If-None-Match", `"`+sha1+`"`)

w.WriteHeader(http.StatusNotModified)
})

got, _, err = client.Repositories.GetCommitSHA1(context.Background(), "o", "r", "tag", sha1)
if err == nil {
t.Errorf("Expected HTTP 304 response")
}

if want := ""; got != want {
t.Errorf("Repositories.GetCommitSHA1 = %v, want %v", got, want)
}
}

func TestRepositoriesService_CompareCommits(t *testing.T) {
client, mux, _, teardown := setup()
defer teardown()
Expand Down