Remove graduated GitHub v3 API preview headers #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1618 +/- ##
==========================================
- Coverage 68.06% 67.92% -0.15%
==========================================
Files 97 97
Lines 8855 8816 -39
==========================================
- Hits 6027 5988 -39
Misses 1912 1912
Partials 916 916
Continue to review full report at Codecov.
|
gmlewis
approved these changes
Aug 27, 2020
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
This looks great, @vikkyomkar ! Thank you!
LGTM.
Awaiting second LGTM before merging.
Contributor
Author
|
@gmlewis can we get a 2nd review on this ? |
Collaborator
|
@wesleimp - do you have time for a review? |
wesleimp
approved these changes
Sep 17, 2020
Collaborator
wesleimp
left a comment
wesleimp
left a comment
There was a problem hiding this comment.
Thank you, @vikkyomkar
LGTM 👌🏼
Collaborator
|
Thank you, @wesleimp ! |
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses below issue
#1616