Remove REST API preview headers that have been promoted out of preview

github/activity_star.go

@@ -8,7 +8,6 @@ package github
 import (
 	"context"
 	"fmt"
-	"strings"
 )
 
 // StarredRepository is returned by ListStarred.
@@ -38,9 +37,6 @@ func (s *ActivityService) ListStargazers(ctx context.Context, owner, repo string
 		return nil, nil, err
 	}
 
-	// TODO: remove custom Accept header when this API fully launches
-	req.Header.Set("Accept", mediaTypeStarringPreview)
-
 	var stargazers []*Stargazer
 	resp, err := s.client.Do(ctx, req, &stargazers)
 	if err != nil {
@@ -86,10 +82,6 @@ func (s *ActivityService) ListStarred(ctx context.Context, user string, opts *Ac
 		return nil, nil, err
 	}
 
-	// TODO: remove custom Accept header when APIs fully launch
-	acceptHeaders := []string{mediaTypeStarringPreview, mediaTypeTopicsPreview}
-	req.Header.Set("Accept", strings.Join(acceptHeaders, ", "))
-
 	var repos []*StarredRepository
 	resp, err := s.client.Do(ctx, req, &repos)
 	if err != nil {

github/activity_star_test.go

@@ -9,7 +9,6 @@ import (
 	"context"
 	"fmt"
 	"net/http"
-	"strings"
 	"testing"
 	"time"
 
@@ -22,7 +21,6 @@ func TestActivityService_ListStargazers(t *testing.T) {
 
 	mux.HandleFunc("/repos/o/r/stargazers", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "GET")
-		testHeader(t, r, "Accept", mediaTypeStarringPreview)
 		testFormValues(t, r, values{
 			"page": "2",
 		})
@@ -62,7 +60,6 @@ func TestActivityService_ListStarred_authenticatedUser(t *testing.T) {
 
 	mux.HandleFunc("/user/starred", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "GET")
-		testHeader(t, r, "Accept", strings.Join([]string{mediaTypeStarringPreview, mediaTypeTopicsPreview}, ", "))
 		fmt.Fprint(w, `[{"starred_at":"2002-02-10T15:30:00Z","repo":{"id":1}}]`)
 	})
 
@@ -98,7 +95,6 @@ func TestActivityService_ListStarred_specifiedUser(t *testing.T) {
 
 	mux.HandleFunc("/users/u/starred", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "GET")
-		testHeader(t, r, "Accept", strings.Join([]string{mediaTypeStarringPreview, mediaTypeTopicsPreview}, ", "))
 		testFormValues(t, r, values{
 			"sort":      "created",
 			"direction": "asc",

github/apps_installation.go

@@ -8,7 +8,6 @@ package github
 import (
 	"context"
 	"fmt"
-	"strings"
 )
 
 // ListRepositories represents the response from the list repos endpoints.
@@ -31,14 +30,6 @@ func (s *AppsService) ListRepos(ctx context.Context, opts *ListOptions) (*ListRe
 		return nil, nil, err
 	}
 
-	// TODO: remove custom Accept headers when APIs fully launch.
-	acceptHeaders := []string{
-		mediaTypeTopicsPreview,
-		mediaTypeRepositoryVisibilityPreview,
-		mediaTypeRepositoryTemplatePreview,
-	}
-	req.Header.Set("Accept", strings.Join(acceptHeaders, ", "))
-
 	var r *ListRepositories
 
 	resp, err := s.client.Do(ctx, req, &r)
@@ -65,14 +56,6 @@ func (s *AppsService) ListUserRepos(ctx context.Context, id int64, opts *ListOpt
 		return nil, nil, err
 	}
 
-	// TODO: remove custom Accept headers when APIs fully launch.
-	acceptHeaders := []string{
-		mediaTypeTopicsPreview,
-		mediaTypeRepositoryVisibilityPreview,
-		mediaTypeRepositoryTemplatePreview,
-	}
-	req.Header.Set("Accept", strings.Join(acceptHeaders, ", "))
-
 	var r *ListRepositories
 	resp, err := s.client.Do(ctx, req, &r)
 	if err != nil {

github/apps_installation_test.go

@@ -9,7 +9,6 @@ import (
 	"context"
 	"fmt"
 	"net/http"
-	"strings"
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
@@ -19,14 +18,8 @@ func TestAppsService_ListRepos(t *testing.T) {
 	client, mux, _, teardown := setup()
 	defer teardown()
 
-	wantAcceptHeaders := []string{
-		mediaTypeTopicsPreview,
-		mediaTypeRepositoryVisibilityPreview,
-		mediaTypeRepositoryTemplatePreview,
-	}
 	mux.HandleFunc("/installation/repositories", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "GET")
-		testHeader(t, r, "Accept", strings.Join(wantAcceptHeaders, ", "))
 		testFormValues(t, r, values{
 			"page":     "1",
 			"per_page": "2",
@@ -60,14 +53,8 @@ func TestAppsService_ListUserRepos(t *testing.T) {
 	client, mux, _, teardown := setup()
 	defer teardown()
 
-	wantAcceptHeaders := []string{
-		mediaTypeTopicsPreview,
-		mediaTypeRepositoryVisibilityPreview,
-		mediaTypeRepositoryTemplatePreview,
-	}
 	mux.HandleFunc("/user/installations/1/repositories", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "GET")
-		testHeader(t, r, "Accept", strings.Join(wantAcceptHeaders, ", "))
 		testFormValues(t, r, values{
 			"page":     "1",
 			"per_page": "2",

github/authorizations.go

@@ -155,7 +155,6 @@ func (s *AuthorizationsService) Check(ctx context.Context, clientID, accessToken
 	if err != nil {
 		return nil, nil, err
 	}
-	req.Header.Set("Accept", mediaTypeOAuthAppPreview)
 
 	a := new(Authorization)
 	resp, err := s.client.Do(ctx, req, a)
@@ -188,7 +187,6 @@ func (s *AuthorizationsService) Reset(ctx context.Context, clientID, accessToken
 	if err != nil {
 		return nil, nil, err
 	}
-	req.Header.Set("Accept", mediaTypeOAuthAppPreview)
 
 	a := new(Authorization)
 	resp, err := s.client.Do(ctx, req, a)
@@ -217,7 +215,6 @@ func (s *AuthorizationsService) Revoke(ctx context.Context, clientID, accessToke
 	if err != nil {
 		return nil, err
 	}
-	req.Header.Set("Accept", mediaTypeOAuthAppPreview)
 
 	return s.client.Do(ctx, req, nil)
 }
@@ -238,7 +235,6 @@ func (s *AuthorizationsService) DeleteGrant(ctx context.Context, clientID, acces
 	if err != nil {
 		return nil, err
 	}
-	req.Header.Set("Accept", mediaTypeOAuthAppPreview)
 
 	return s.client.Do(ctx, req, nil)
 }

github/authorizations_test.go

@@ -21,7 +21,6 @@ func TestAuthorizationsService_Check(t *testing.T) {
 	mux.HandleFunc("/applications/id/token", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "POST")
 		testBody(t, r, `{"access_token":"a"}`+"\n")
-		testHeader(t, r, "Accept", mediaTypeOAuthAppPreview)
 		fmt.Fprint(w, `{"id":1}`)
 	})
 
@@ -58,7 +57,6 @@ func TestAuthorizationsService_Reset(t *testing.T) {
 	mux.HandleFunc("/applications/id/token", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "PATCH")
 		testBody(t, r, `{"access_token":"a"}`+"\n")
-		testHeader(t, r, "Accept", mediaTypeOAuthAppPreview)
 		fmt.Fprint(w, `{"ID":1}`)
 	})
 
@@ -95,7 +93,6 @@ func TestAuthorizationsService_Revoke(t *testing.T) {
 	mux.HandleFunc("/applications/id/token", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "DELETE")
 		testBody(t, r, `{"access_token":"a"}`+"\n")
-		testHeader(t, r, "Accept", mediaTypeOAuthAppPreview)
 		w.WriteHeader(http.StatusNoContent)
 	})
 
@@ -123,7 +120,6 @@ func TestDeleteGrant(t *testing.T) {
 	mux.HandleFunc("/applications/id/grant", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "DELETE")
 		testBody(t, r, `{"access_token":"a"}`+"\n")
-		testHeader(t, r, "Accept", mediaTypeOAuthAppPreview)
 	})
 
 	ctx := context.Background()

github/github.go

@@ -49,84 +49,9 @@ const (
 
 	// Media Type values to access preview APIs
 
-	// https://developer.github.com/changes/2014-12-09-new-attributes-for-stars-api/
-	mediaTypeStarringPreview = "application/vnd.github.v3.star+json"
-
-	// https://help.github.com/enterprise/2.4/admin/guides/migrations/exporting-the-github-com-organization-s-repositories/
-	mediaTypeMigrationsPreview = "application/vnd.github.wyandotte-preview+json"
-
-	// https://developer.github.com/changes/2016-04-06-deployment-and-deployment-status-enhancements/
-	mediaTypeDeploymentStatusPreview = "application/vnd.github.ant-man-preview+json"
-
-	// https://developer.github.com/changes/2018-10-16-deployments-environments-states-and-auto-inactive-updates/
-	mediaTypeExpandDeploymentStatusPreview = "application/vnd.github.flash-preview+json"
-
-	// https://developer.github.com/changes/2016-05-12-reactions-api-preview/
-	mediaTypeReactionsPreview = "application/vnd.github.squirrel-girl-preview"
-
-	// https://developer.github.com/changes/2016-05-23-timeline-preview-api/
-	mediaTypeTimelinePreview = "application/vnd.github.mockingbird-preview+json"
-
-	// https://developer.github.com/changes/2016-09-14-projects-api/
-	mediaTypeProjectsPreview = "application/vnd.github.inertia-preview+json"
-
-	// https://developer.github.com/changes/2017-01-05-commit-search-api/
-	mediaTypeCommitSearchPreview = "application/vnd.github.cloak-preview+json"
-
-	// https://developer.github.com/changes/2017-02-28-user-blocking-apis-and-webhook/
-	mediaTypeBlockUsersPreview = "application/vnd.github.giant-sentry-fist-preview+json"
-
 	// https://developer.github.com/changes/2017-05-23-coc-api/
 	mediaTypeCodesOfConductPreview = "application/vnd.github.scarlet-witch-preview+json"
 
-	// https://developer.github.com/changes/2017-07-17-update-topics-on-repositories/
-	mediaTypeTopicsPreview = "application/vnd.github.mercy-preview+json"
-
-	// https://developer.github.com/changes/2018-03-16-protected-branches-required-approving-reviews/
-	mediaTypeRequiredApprovingReviewsPreview = "application/vnd.github.luke-cage-preview+json"
-
-	// https://developer.github.com/enterprise/2.13/v3/repos/pre_receive_hooks/
-	mediaTypePreReceiveHooksPreview = "application/vnd.github.eye-scream-preview"
-
-	// https://developer.github.com/changes/2018-02-22-protected-branches-required-signatures/
-	mediaTypeSignaturePreview = "application/vnd.github.zzzax-preview+json"
-
-	// https://developer.github.com/changes/2018-09-05-project-card-events/
-	mediaTypeProjectCardDetailsPreview = "application/vnd.github.starfox-preview+json"
-
-	// https://developer.github.com/changes/2018-12-18-interactions-preview/
-	mediaTypeInteractionRestrictionsPreview = "application/vnd.github.sombra-preview+json"
-
-	// https://developer.github.com/changes/2019-03-14-enabling-disabling-pages/
-	mediaTypeEnablePagesAPIPreview = "application/vnd.github.switcheroo-preview+json"
-
-	// https://developer.github.com/changes/2019-04-24-vulnerability-alerts/
-	mediaTypeRequiredVulnerabilityAlertsPreview = "application/vnd.github.dorian-preview+json"
-
-	// https://developer.github.com/changes/2019-06-04-automated-security-fixes/
-	mediaTypeRequiredAutomatedSecurityFixesPreview = "application/vnd.github.london-preview+json"
-
-	// https://developer.github.com/changes/2019-05-29-update-branch-api/
-	mediaTypeUpdatePullRequestBranchPreview = "application/vnd.github.lydian-preview+json"
-
-	// https://developer.github.com/changes/2019-04-11-pulls-branches-for-commit/
-	mediaTypeListPullsOrBranchesForCommitPreview = "application/vnd.github.groot-preview+json"
-
-	// https://docs.github.com/en/free-pro-team@latest/rest/reference/previews/#repository-creation-permissions
-	mediaTypeMemberAllowedRepoCreationTypePreview = "application/vnd.github.surtur-preview+json"
-
-	// https://docs.github.com/en/free-pro-team@latest/rest/reference/previews/#create-and-use-repository-templates
-	mediaTypeRepositoryTemplatePreview = "application/vnd.github.baptiste-preview+json"
-
-	// https://developer.github.com/changes/2019-10-03-multi-line-comments/
-	mediaTypeMultiLineCommentsPreview = "application/vnd.github.comfort-fade-preview+json"
-
-	// https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/
-	mediaTypeOAuthAppPreview = "application/vnd.github.doctor-strange-preview+json"
-
-	// https://developer.github.com/changes/2019-12-03-internal-visibility-changes/
-	mediaTypeRepositoryVisibilityPreview = "application/vnd.github.nebula-preview+json"
-
 	// https://developer.github.com/changes/2018-12-10-content-attachments-api/
 	mediaTypeContentAttachmentsPreview = "application/vnd.github.corsair-preview+json"
 )

github/interactions_orgs.go

@@ -20,9 +20,6 @@ func (s *InteractionsService) GetRestrictionsForOrg(ctx context.Context, organiz
 		return nil, nil, err
 	}
 
-	// TODO: remove custom Accept header when this API fully launches.
-	req.Header.Set("Accept", mediaTypeInteractionRestrictionsPreview)
-
 	organizationInteractions := new(InteractionRestriction)
 
 	resp, err := s.client.Do(ctx, req, organizationInteractions)
@@ -50,9 +47,6 @@ func (s *InteractionsService) UpdateRestrictionsForOrg(ctx context.Context, orga
 		return nil, nil, err
 	}
 
-	// TODO: remove custom Accept header when this API fully launches.
-	req.Header.Set("Accept", mediaTypeInteractionRestrictionsPreview)
-
 	organizationInteractions := new(InteractionRestriction)
 
 	resp, err := s.client.Do(ctx, req, organizationInteractions)
@@ -73,8 +67,5 @@ func (s *InteractionsService) RemoveRestrictionsFromOrg(ctx context.Context, org
 		return nil, err
 	}
 
-	// TODO: remove custom Accept header when this API fully launches.
-	req.Header.Set("Accept", mediaTypeInteractionRestrictionsPreview)
-
 	return s.client.Do(ctx, req, nil)
 }

github/interactions_orgs_test.go

@@ -21,7 +21,6 @@ func TestInteractionsService_GetRestrictionsForOrgs(t *testing.T) {
 
 	mux.HandleFunc("/orgs/o/interaction-limits", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "GET")
-		testHeader(t, r, "Accept", mediaTypeInteractionRestrictionsPreview)
 		fmt.Fprint(w, `{"origin":"organization"}`)
 	})
 
@@ -62,7 +61,6 @@ func TestInteractionsService_UpdateRestrictionsForOrg(t *testing.T) {
 		json.NewDecoder(r.Body).Decode(v)
 
 		testMethod(t, r, "PUT")
-		testHeader(t, r, "Accept", mediaTypeInteractionRestrictionsPreview)
 		if !cmp.Equal(v, input) {
 			t.Errorf("Request body = %+v, want %+v", v, input)
 		}
@@ -101,7 +99,6 @@ func TestInteractionsService_RemoveRestrictionsFromOrg(t *testing.T) {
 
 	mux.HandleFunc("/orgs/o/interaction-limits", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "DELETE")
-		testHeader(t, r, "Accept", mediaTypeInteractionRestrictionsPreview)
 	})
 
 	ctx := context.Background()

github/interactions_repos.go

@@ -20,9 +20,6 @@ func (s *InteractionsService) GetRestrictionsForRepo(ctx context.Context, owner,
 		return nil, nil, err
 	}
 
-	// TODO: remove custom Accept header when this API fully launches.
-	req.Header.Set("Accept", mediaTypeInteractionRestrictionsPreview)
-
 	repositoryInteractions := new(InteractionRestriction)
 
 	resp, err := s.client.Do(ctx, req, repositoryInteractions)
@@ -50,9 +47,6 @@ func (s *InteractionsService) UpdateRestrictionsForRepo(ctx context.Context, own
 		return nil, nil, err
 	}
 
-	// TODO: remove custom Accept header when this API fully launches.
-	req.Header.Set("Accept", mediaTypeInteractionRestrictionsPreview)
-
 	repositoryInteractions := new(InteractionRestriction)
 
 	resp, err := s.client.Do(ctx, req, repositoryInteractions)
@@ -73,8 +67,5 @@ func (s *InteractionsService) RemoveRestrictionsFromRepo(ctx context.Context, ow
 		return nil, err
 	}
 
-	// TODO: remove custom Accept header when this API fully launches.
-	req.Header.Set("Accept", mediaTypeInteractionRestrictionsPreview)
-
 	return s.client.Do(ctx, req, nil)
 }

github/interactions_repos_test.go

@@ -21,7 +21,6 @@ func TestInteractionsService_GetRestrictionsForRepo(t *testing.T) {
 
 	mux.HandleFunc("/repos/o/r/interaction-limits", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "GET")
-		testHeader(t, r, "Accept", mediaTypeInteractionRestrictionsPreview)
 		fmt.Fprint(w, `{"origin":"repository"}`)
 	})
 
@@ -62,7 +61,6 @@ func TestInteractionsService_UpdateRestrictionsForRepo(t *testing.T) {
 		json.NewDecoder(r.Body).Decode(v)
 
 		testMethod(t, r, "PUT")
-		testHeader(t, r, "Accept", mediaTypeInteractionRestrictionsPreview)
 		if !cmp.Equal(v, input) {
 			t.Errorf("Request body = %+v, want %+v", v, input)
 		}
@@ -101,7 +99,6 @@ func TestInteractionsService_RemoveRestrictionsFromRepo(t *testing.T) {
 
 	mux.HandleFunc("/repos/o/r/interaction-limits", func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "DELETE")
-		testHeader(t, r, "Accept", mediaTypeInteractionRestrictionsPreview)
 	})
 
 	ctx := context.Background()