Skip to content

Update active committers struct #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Update active committers struct #3257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3170eaa
Update active committers struct
ganeshkumarsv Sep 4, 2024
671b1fd
go fmt
ganeshkumarsv Sep 4, 2024
5712de9
Update test cases for active committers
ganeshkumarsv Sep 4, 2024
66567f8
go fmt
ganeshkumarsv Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions github/billing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,11 @@ type StorageBilling struct {

// ActiveCommitters represents the total active committers across all repositories in an Organization.
type ActiveCommitters struct {
TotalAdvancedSecurityCommitters int `json:"total_advanced_security_committers"`
Repositories []*RepositoryActiveCommitters `json:"repositories,omitempty"`
TotalAdvancedSecurityCommitters int `json:"total_advanced_security_committers"`
TotalCount int `json:"total_count"`
MaximumAdvancedSecurityCommitters int `json:"maximum_advanced_security_committers"`
PurchasedAdvancedSecurityCommitters int `json:"purchased_advanced_security_committers"`
Repositories []*RepositoryActiveCommitters `json:"repositories,omitempty"`
}

// RepositoryActiveCommitters represents active committers on each repository.
Expand Down
9 changes: 8 additions & 1 deletion github/billing_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,14 @@ func TestBillingService_GetAdvancedSecurityActiveCommittersOrg(t *testing.T) {
testMethod(t, r, "GET")
fmt.Fprint(w, `{
"total_advanced_security_committers": 2,
"total_count": 2,
"maximum_advanced_security_committers": 3,
"purchased_advanced_security_committers": 4,
"repositories": [
{
"name": "octocat-org/Hello-World",
"advanced_security_committers": 2,

"advanced_security_committers_breakdown": [
{
"user_login": "octokitten",
Expand All @@ -459,7 +463,10 @@ func TestBillingService_GetAdvancedSecurityActiveCommittersOrg(t *testing.T) {
}

want := &ActiveCommitters{
TotalAdvancedSecurityCommitters: 2,
TotalAdvancedSecurityCommitters: 2,
TotalCount: 2,
MaximumAdvancedSecurityCommitters: 3,
PurchasedAdvancedSecurityCommitters: 4,
Repositories: []*RepositoryActiveCommitters{
{
Name: String("octocat-org/Hello-World"),
Expand Down