Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ linters:
- modernize
- musttag
- nakedret
- nolintlint
- paralleltest
- perfsprint
- revive
Expand Down Expand Up @@ -88,6 +89,9 @@ linters:
modernize:
disable:
- omitzero # TODO: fix
nolintlint:
allow-unused: true
require-specific: true
perfsprint:
errorf: true
strconcat: false
Expand Down
1 change: 0 additions & 1 deletion github/issue_import_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ func TestIssueImportService_CheckStatusSince(t *testing.T) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeIssueImportAPI)
w.WriteHeader(http.StatusOK)
//nolint:fmtpercentv
assertWrite(t, w, fmt.Appendf(nil, "[%s]", issueImportResponseJSON))
})

Expand Down
1 change: 0 additions & 1 deletion github/migrations_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ func TestMigrationService_ListMigrations(t *testing.T) {
testHeader(t, r, "Accept", mediaTypeMigrationsPreview)

w.WriteHeader(http.StatusOK)
//nolint:fmtpercentv
assertWrite(t, w, fmt.Appendf(nil, "[%s]", migrationJSON))
})

Expand Down
1 change: 0 additions & 1 deletion github/migrations_user_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ func TestMigrationService_ListUserMigrations(t *testing.T) {
testHeader(t, r, "Accept", mediaTypeMigrationsPreview)

w.WriteHeader(http.StatusOK)
//nolint:fmtpercentv
assertWrite(t, w, fmt.Appendf(nil, "[%s]", userMigrationJSON))
})

Expand Down
2 changes: 1 addition & 1 deletion tools/gen-release-notes/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ func genRefLines(breaking, nonBreaking []string) (ref, refNon []string) {

func newChangesSinceRelease(priorRelease string) string {
url := fmt.Sprintf("%v/compare/%v...master", baseWebURL, priorRelease)
resp, err := http.Get(url) //nolint: gosec
resp, err := http.Get(url) //nolint:gosec
must(err)
defer resp.Body.Close()

Expand Down
2 changes: 1 addition & 1 deletion tools/metadata/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ GET /undocumented/{undocumented_id}
`, "")
}

//nolint:tparallel,paralleltest // cannot use t.Parallel() when helper calls t.Setenv
//nolint:paralleltest // cannot use t.Parallel() when helper calls t.Setenv
func TestUpdateOpenAPI(t *testing.T) {
testServer := newTestServer(t, "main", map[string]any{
"api.github.com/api.github.com.json": openapi3.T{
Expand Down
Loading