-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add support for Enterprise GitHub App Installation APIs #3830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add support for Enterprise GitHub App Installation APIs #3830
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3830 +/- ##
==========================================
+ Coverage 92.38% 92.41% +0.03%
==========================================
Files 196 197 +1
Lines 14094 14152 +58
==========================================
+ Hits 13021 13079 +58
Misses 884 884
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just reviewed the API surface and I think some of the function names need re-working before doing a deeper review.
|
@stevehipwell Thanks for the suggestions, I have change the name for both - |
…ppAccessibleRepositories
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't think the API is consistent, how about the following changes to make the API consistent by using an App prefix with all unnecessary padding removed?
ListInstallableAppOrganizations->ListAppInstallableOrganizationsListOrganizationAppAccessibleRepositories->ListAppAccessibleOrganizationRepositoriesListAppOrganizationInstallations->ListAppInstallationsInstallEnterpriseOrganizationApp->InstallAppUninstallEnterpriseOrganizationApp->UninstallApp
I have implemented the following changes as requested |
|
@alexandear Thanks for all suggestions, I made some changes as requested -
|
Relates-to: #3829
This PR add support for the following API endpoints -
REST API endpoints for Github App Installation