Skip to content

Conversation

@erickoledadevrel
Copy link
Contributor

Fixes #566

  • [X ] npm test succeeds
  • [ X] Pull request has been squashed into 1 commit
  • [ X] I did NOT manually make changes to anything in apis/
  • [ X] Code coverage does not decrease (if any source code was changed)
  • [ X] Appropriate JSDoc comments were updated in source code (if applicable)
  • [ X] Approprate changes to readme/docs are included in PR

The process.exit replaced a returnthat was failing a lint check, but ended up causing the generator to quit before the generation was complete.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 4, 2016
The `process.exit` replaced a `return`that was failing a lint check, but ended up causing the generator to quit before the generation was complete.
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 4, 2016
@jmdobry jmdobry merged commit d99ca56 into googleapis:master May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants