Skip to content

Conversation

@jmdobry
Copy link
Contributor

@jmdobry jmdobry commented Aug 23, 2016

  • npm test succeeds
  • Pull request has been squashed into 1 commit
  • I did NOT manually make changes to anything in apis/
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate JSDoc comments were updated in source code (if applicable)
  • Appropriate changes to readme/docs are included in PR

Fixes #501
Fixes #618
Fixes #621

Before

drive.files.export({
  fileId: 'asxKJod9s79', // A Google Doc
  mimeType: 'application/pdf',
  encoding: null // This is ignored
}, , function (err, buffer) {
  // Oh no! buffer got incorrectly interpreted as a string!
});

After

drive.files.export({
  fileId: 'asxKJod9s79', // A Google Doc
  mimeType: 'application/pdf'
}, {
  encoding: null // Make sure we get the binary data
}, function (err, buffer) {
  // Nice, the buffer is actually a Buffer!
});

@jmdobry jmdobry added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. in progress labels Aug 23, 2016
@jmdobry jmdobry self-assigned this Aug 23, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2016
@codecov-io
Copy link

codecov-io commented Aug 23, 2016

Current coverage is 88.56% (diff: 100%)

Merging #623 into master will not change coverage

@@             master       #623   diff @@
==========================================
  Files             8          8          
  Lines           271        271          
  Methods          41         41          
  Messages          0          0          
  Branches         59         59          
==========================================
  Hits            240        240          
  Misses           31         31          
  Partials          0          0          

Powered by Codecov. Last update 769d760...299e882

@jmdobry
Copy link
Contributor Author

jmdobry commented Aug 23, 2016

@JustinBeckwith Looks good to you?

@jmdobry jmdobry merged commit bc2c108 into master Aug 23, 2016
@jmdobry jmdobry deleted the feat-options branch August 23, 2016 20:47
@jmdobry jmdobry added done and removed in progress labels Aug 23, 2016
@jmdobry jmdobry mentioned this pull request Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants