Publish snapshot artifacts to Sonatype fails

[sormuras]

The deployment of snapshot artifacts failed due to a 401 Unauthorized error: https://github.com/google/google-java-format/runs/1455239922

Note: a run on a fork reports "green", as the publish step is skipped: https://github.com/sormuras/google-java-format/actions/runs/383909185

These are the lines in question that trigger the upload:

google-java-format/.github/workflows/ci.yml

Lines 50 to 58 in c1dd08d

	- name: 'Set up JDK 15'
	uses: actions/setup-java@v1
	with:
	java-version: 15
	server-id: sonatype-nexus-snapshots
	server-username: CI_DEPLOY_USERNAME
	server-password: CI_DEPLOY_PASSWORD
	- name: 'Publish'
	run: mvn source:jar deploy -B -DskipTests=true -Dinvoker.skip=true -Dmaven.javadoc.skip=true

Reading https://github.com/actions/setup-java#publishing-using-apache-maven again, I think that all required credentials are given, passed, and written to correct configuration files. It should, if it worked, render the util/settings.xml superseded.

[cushon]

Looking at the example in those docs, MAVEN_USERNAME is commented as being an env variable, and there's a separate step that sets the env variable to the 'secret':

      env:
        MAVEN_USERNAME: maven_username123
        MAVEN_CENTRAL_TOKEN: ${{ secrets.MAVEN_CENTRAL_TOKEN }}

Maybe we need to add a similar env: section, or else use e.g. ${{ secrets. CI_DEPLOY_USERNAME }} directly?

[sormuras]

... there's a separate step that sets the env variable to the 'secret': ...

Aye. That env section is missing. Do you want to add those two lines directly or should I create a PR?

      - name: 'Publish'
        env:
          CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }}
          CI_DEPLOY_PASSWORD: ${{ secrets.CI_DEPLOY_PASSWORD }}
        run: mvn source:jar deploy -B -DskipTests=true -Dinvoker.skip=true -Dmaven.javadoc.skip=true

[cushon]

I'll take care of it, thanks for confirming!

[sormuras]

Adding those 3 (env: + 1 line per variable) missing lines should make the CI workflow green again...