Skip to content

Conversation

@sormuras
Copy link
Contributor

@sormuras sormuras commented Aug 20, 2017

This PR adds file Java9SourceTest.java to show the problems with Java 9 syntax features and the new javac version included in sormuras@fee1ed2

This PR also fixes a typo in TryWithResources.input and TryWithResources.output.

@sormuras sormuras changed the title Add (ignored) test cases for issue #155 and #176 Add (ignored) test cases for Java 9 syntax related issues Aug 20, 2017
Fix a typo in TryWithResources.input and TryWithResources.output
@sormuras
Copy link
Contributor Author

Adding line Options.instance(context).put("-source", "9"); to com/google/googlejavaformat/java/Formatter.java:138 solves issue #176!

#75 needs more visitor love in com.google.googlejavaformat.java.JavaInputAstVisitor#visitModule
#155 needs to learn not to throw java.lang.ClassCastException: org.openjdk.tools.javac.tree.JCTree$JCIdent cannot be cast to org.openjdk.source.tree.VariableTree

@sormuras
Copy link
Contributor Author

Superseded by #178

@sormuras sormuras closed this Aug 20, 2017
@sormuras sormuras deleted the failing-input-for-155-and-176 branch August 20, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants