Skip to content

Reset to 1.5-SNAPSHOT #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Reset to 1.5-SNAPSHOT #213

wants to merge 2 commits into from

Conversation

@sormuras
Copy link
Contributor

@sormuras sormuras commented Oct 14, 2017

The cleanup commit 2ec27b5 set it back to 1.0...

@cushon
Copy link
Collaborator

cushon commented Oct 14, 2017

Argh. Thanks for spotting this, it's an issue with our sync process.

I'm working on a change to read the version from META-INF/maven/com.google.googlejavaformat/google-java-format/pom.properties at runtime instead of trying to keep it up to date by hand, sort of like [1]. Sound OK?

[1] https://github.com/google/error-prone/blob/6bf224e92d632c8485f424f3c2faefa3b1863b27/check_api/src/main/java/com/google/errorprone/ErrorProneVersion.java#L36

@sormuras
Copy link
Contributor Author

sormuras commented Oct 14, 2017

Sounds good. Closing this PR in favor of your dynamic version.

@sormuras sormuras closed this Oct 14, 2017
@sormuras sormuras deleted the patch-1 branch October 14, 2017 04:38
cushon referenced this pull request Oct 14, 2017
@jbduncan @cushon
Remove redundant type arguments
2ec27b5 
and add parameter commands in places where the parameters aren't very
self-documenting.

Fixes #130

MOE_MIGRATED_REVID=172167200
@sormuras sormuras mentioned this pull request Oct 15, 2017
Closed
cushon added a commit that referenced this pull request Oct 17, 2017
@cushon
Load the version number at runtime
352aac7 
instead of baking in a static version string.

See #213, #188, etc.

MOE_MIGRATED_REVID=172404513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sormuras @cushon @googlebot