Skip to content

Conversation

@sormuras
Copy link
Contributor

@sormuras sormuras commented Aug 26, 2021

This PR implements Java 9's ToolProvider SPI with GoogleJavaFormatToolProvider using google-java-format as the name.

jar --describe-module --file google-java-format-HEAD-SNAPSHOT.jar yields:

No module descriptor found. Derived automatic module.

com.google.googlejavaformat automatic
requires java.base mandated

provides java.util.spi.ToolProvider with com.google.googlejavaformat.java.GoogleJavaFormatToolProvider

contains com.google.googlejavaformat
contains com.google.googlejavaformat.java
contains com.google.googlejavaformat.java.filer
contains com.google.googlejavaformat.java.java14
contains com.google.googlejavaformat.java.javadoc
main-class com.google.googlejavaformat.java.Main

Same new provides line is emitted for the google-java-format-HEAD-SNAPSHOT-all-deps.jar file.

Closes #561

@google-cla google-cla bot added the cla: yes label Aug 26, 2021
@sormuras sormuras marked this pull request as ready for review August 26, 2021 20:26
import org.junit.runners.JUnit4;

/** Tests for {@link GoogleJavaFormatToolProvider}. */
@RunWith(JUnit4.class)
Copy link
Contributor Author

@sormuras sormuras Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw. this hurts a bit. When will Google upgrade to Jupiter aka JUnit 5️⃣ ? 🙂

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any news on that front :(

copybara-service bot pushed a commit that referenced this pull request Sep 15, 2021
FUTURE_COPYBARA_INTEGRATE_REVIEW=#656 from sormuras:issues/561-toolprovider 82130f3
PiperOrigin-RevId: 396931821
@copybara-service copybara-service bot mentioned this pull request Sep 15, 2021
copybara-service bot pushed a commit that referenced this pull request Sep 15, 2021
FUTURE_COPYBARA_INTEGRATE_REVIEW=#656 from sormuras:issues/561-toolprovider 82130f3
PiperOrigin-RevId: 396931821
copybara-service bot pushed a commit that referenced this pull request Sep 17, 2021
FUTURE_COPYBARA_INTEGRATE_REVIEW=#656 from sormuras:issues/561-toolprovider 82130f3
PiperOrigin-RevId: 396880150
@copybara-service copybara-service bot mentioned this pull request Sep 17, 2021
cushon pushed a commit that referenced this pull request Sep 19, 2021
COPYBARA_INTEGRATE_REVIEW=#656 from sormuras:issues/561-toolprovider 82130f3
PiperOrigin-RevId: 396936217
@cushon
Copy link
Collaborator

cushon commented Sep 19, 2021

Thanks for the PR! This has been merged as part of 2c5d5fd

(There was an issue with the automation that resulted in it getting merged into the same commit as some other changes.)

@cushon cushon closed this Sep 19, 2021
@sormuras
Copy link
Contributor Author

Thanks for the heads-up and in the light of that, I'll close the originated issue #561

@sormuras sormuras deleted the issues/561-toolprovider branch September 20, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement ToolProvider SPI

2 participants