-
Notifications
You must be signed in to change notification settings - Fork 903
Implement ToolProvider SPI
#656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| import org.junit.runners.JUnit4; | ||
|
|
||
| /** Tests for {@link GoogleJavaFormatToolProvider}. */ | ||
| @RunWith(JUnit4.class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. this hurts a bit. When will Google upgrade to Jupiter aka JUnit 5️⃣ ? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any news on that front :(
|
Thanks for the PR! This has been merged as part of 2c5d5fd (There was an issue with the automation that resulted in it getting merged into the same commit as some other changes.) |
|
Thanks for the heads-up and in the light of that, I'll close the originated issue #561 |
This PR implements Java 9's
ToolProviderSPI withGoogleJavaFormatToolProviderusinggoogle-java-formatas the name.jar --describe-module --file google-java-format-HEAD-SNAPSHOT.jaryields:Same new
providesline is emitted for thegoogle-java-format-HEAD-SNAPSHOT-all-deps.jarfile.Closes #561