Skip to content

Add test for #389 Skip having non-zero value on reused pages #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mspielberg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add test for #389 Skip having non-zero value on reused pages #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 89 additions & 0 deletions tcpassembly/assembly_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,95 @@ func TestCacheLargePacket(t *testing.T) {
})
}

func TestReuseFromCache(t *testing.T) {
test(t, []testSequence{
{
in: layers.TCP{
SrcPort: 1,
DstPort: 2,
Seq: 1000,
SYN: true,
BaseLayer: layers.BaseLayer{Payload: []byte{1, 2, 3}},
},
want: []Reassembly{
Reassembly{
Start: true,
Bytes: []byte{1, 2, 3},
},
},
},
{
// start allocating pages in connection; this one has Skip: 6
in: layers.TCP{
SrcPort: 1,
DstPort: 2,
Seq: 1010,
BaseLayer: layers.BaseLayer{Payload: []byte{2, 2, 3}},
},
want: []Reassembly{},
},
{
// ensure we only release 1 packet from the connection by introducing another Skip: 4
in: layers.TCP{
SrcPort: 1,
DstPort: 2,
Seq: 1017,
BaseLayer: layers.BaseLayer{Payload: []byte{3, 2, 3}},
},
want: []Reassembly{},
},
{
in: layers.TCP{
SrcPort: 1,
DstPort: 2,
Seq: 1020,
BaseLayer: layers.BaseLayer{Payload: []byte{4, 2, 3}},
},
want: []Reassembly{},
},
{
in: layers.TCP{
SrcPort: 1,
DstPort: 2,
Seq: 1023,
BaseLayer: layers.BaseLayer{Payload: []byte{5, 2, 3}},
},
want: []Reassembly{
// released from connection; goes into the page cache with Skip: 6
Reassembly{
Skip: 6,
Bytes: []byte{2, 2, 3},
},
},
},
{
// re-uses from page cache
in: layers.TCP{
SrcPort: 1,
DstPort: 2,
Seq: 1026,
BaseLayer: layers.BaseLayer{Payload: []byte{6, 2, 3}},
},
want: []Reassembly{
Reassembly{
Skip: 4,
Bytes: []byte{3, 2, 3},
},
Reassembly{
Bytes: []byte{4, 2, 3},
},
Reassembly{
Bytes: []byte{5, 2, 3},
},
Reassembly{
// Should have Skip:0 when it reaches the stream
Bytes: []byte{6, 2, 3},
},
},
},
})
}

func BenchmarkSingleStream(b *testing.B) {
t := layers.TCP{
SrcPort: 1,
Expand Down