Add option to enable/disable unknown fields in OCI config #12073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl797846468
branch
from
a29e098 to
2144f45
Compare
PiperOrigin-RevId: 797891905
copybara-service
bot
force-pushed
the
test/cl797846468
branch
from
2144f45 to
b60a9bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to enable/disable unknown fields in OCI config
Currently in OCI config it is possible to add any extra json data, which will be ignored by runsc.
I found it is a bit confusing when was learning OCI implementation of gvisor (adding wrong/non existent fields does not produce any error or warning), therefore decided to add flag
allow-unknown-fields, which istrueby default (does not modify current behavior).In case of being
false, gvisor produces error like this:FUTURE_COPYBARA_INTEGRATE_REVIEW=#12052 from ioterw:allow_unknown_fields 0662917