Fix error when applying upperdir tar snapshot containing empty files #12229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanlanigansmith
force-pushed
the
dylanlanigansmith-fix-mknodFromTar-writing-empty-files
branch
from
01fa7c6 to
a6d6a5d
Compare
ayushr2
reviewed
Oct 17, 2025
Collaborator
ayushr2
left a comment
ayushr2
left a comment
There was a problem hiding this comment.
Thanks for your contribution and for also adding tests!
Added size check to prevent sentry tmpfs mknodFromTar from trying to write empty files, this caused running containers from a snapshot from upper tar to fail when empty files were in the archive.
dylanlanigansmith
force-pushed
the
dylanlanigansmith-fix-mknodFromTar-writing-empty-files
branch
from
a6d6a5d to
63b807f
Compare
ayushr2
approved these changes
Oct 17, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
Added size check to prevent sentry tmpfs mknodFromTar from trying to write empty files, this caused running containers from a snapshot from upper tar to fail when empty files were in the archive. Fixes #12228 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12229 from dylanlanigansmith:dylanlanigansmith-fix-mknodFromTar-writing-empty-files 63b807f PiperOrigin-RevId: 820766211
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
Added size check to prevent sentry tmpfs mknodFromTar from trying to write empty files, this caused running containers from a snapshot from upper tar to fail when empty files were in the archive. Fixes #12228 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12229 from dylanlanigansmith:dylanlanigansmith-fix-mknodFromTar-writing-empty-files 63b807f PiperOrigin-RevId: 820766211
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
Added size check to prevent sentry tmpfs mknodFromTar from trying to write empty files, this caused running containers from a snapshot from upper tar to fail when empty files were in the archive. Fixes #12228 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12229 from dylanlanigansmith:dylanlanigansmith-fix-mknodFromTar-writing-empty-files 63b807f PiperOrigin-RevId: 820766211
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
Added size check to prevent sentry tmpfs mknodFromTar from trying to write empty files, this caused running containers from a snapshot from upper tar to fail when empty files were in the archive. Fixes #12228 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12229 from dylanlanigansmith:dylanlanigansmith-fix-mknodFromTar-writing-empty-files 63b807f PiperOrigin-RevId: 820766211
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
Added size check to prevent sentry tmpfs mknodFromTar from trying to write empty files, this caused running containers from a snapshot from upper tar to fail when empty files were in the archive. Fixes #12228 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12229 from dylanlanigansmith:dylanlanigansmith-fix-mknodFromTar-writing-empty-files 63b807f PiperOrigin-RevId: 820766211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added size check to prevent sentry tmpfs mknodFromTar from trying to write empty files, this caused running containers from a snapshot from upper tar to fail when empty files were in the archive.
Fixes #12228