Skip to content

runsc/cmd: fix unintended FD closing in gofer #12236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
+5 −1
Merged

runsc/cmd: fix unintended FD closing in gofer #12236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion runsc/cmd/gofer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ func (g *Gofer) Execute(_ context.Context, f *flag.FlagSet, args ...any) subcomm
defer cleanupUnmounter()
}
}
goferToHostRPC.Close()
if g.applyCaps {
overrides := g.syncFDs.flags()
overrides["apply-caps"] = "false"
Expand All @@ -207,6 +206,11 @@ func (g *Gofer) Execute(_ context.Context, f *flag.FlagSet, args ...any) subcomm
panic("unreachable")
}

// This can't happen until after setCapsAndCallSelf(), since otherwise the
// re-executed gofer may reuse goferToHostRPCFD's file descriptor for an
// unrelated file.
goferToHostRPC.Close()

// Start profiling. This will be a noop if no profiling arguments were passed.
profileOpts := profile.MakeOpts(&g.profileFDs, conf.ProfileGCInterval)
g.stopProfiling = profile.Start(profileOpts)
Expand Down
Loading