Fix ENHANCE_YOUR_CALM too_many_pings error #158
Conversation
agent/utils/utils.go
Outdated
| } | ||
| defer proxyResp.Body.Close() | ||
| defer func() { | ||
| io.Copy(io.Discard, proxyResp.Body) |
There was a problem hiding this comment.
I'm not sure if this is safe to do in the case of listing the pending requests.
The response from the proxy could be arbitrarily large, and in fact, being too large is probably the main way for this issue to be hit in this particular case.
If the response is very large, then the agent will have to read through the entire response body before it attempts to list the pending requests again.
That means we could be introducing an arbitrarily large delay (assuming an arbitrarily long response) that blocks all requests for this backend from being processed.
There was a problem hiding this comment.
Removed draining the response body from List Pending Requests and kept it in the agent/response.
Given the nature of our traffic, I suppose that is the major contributor. We don't see any ENHANCE_YOUR_CALM errors post draining there.
EmperorGentoo
force-pushed
the
master
branch
from
7857839 to
95d1fee
Compare
EmperorGentoo
force-pushed
the
master
branch
from
95d1fee to
ef2ff8e
Compare
2 participants
The proxy agent faces an ENHANCE_YOUR_CALM error leading to closed connections. A similar problem has been discussed in this article as well: https://blog.cloudflare.com/go-and-enhance-your-calm/
The issue seems to be with how resp.Body.Close() works in golang.