Skip to content

Conversation

@whuang8
Copy link

@whuang8 whuang8 commented Mar 27, 2021

Resolves #2

Errors Fixed

$ golint ./...
agent/agent.go:239:6: should omit values from range; this loop is equivalent to `for range ...`
agent/agent.go:261:6: should omit values from range; this loop is equivalent to `for range ...`
agent/banner/banner.go:143:3: struct field FavIconUrl should be FavIconURL
agent/banner/banner.go:188:9: if block ends with a return statement, so drop this else and outdent its block
agent/metrics/metrics.go:51:6: exported type MetricHandler should have comment or be unexported
agent/metrics/metrics.go:150:11: should omit 2nd value from range; this loop is equivalent to `for key := range ...`
agent/metrics/metrics.go:181:1: exported method MetricHandler.GetResponseCountMetricType should have comment or be unexported
agent/utils/utils.go:130:26: error strings should not be capitalized or end with punctuation or a newline
agent/utils/utils.go:141:26: error strings should not be capitalized or end with punctuation or a newline
agent/websockets/shim.go:256:1: exported function ShimBody should have comment or be unexported
testing/runlocal/main.go:60:1: exported function RunLocalProxy should have comment or be unexported

var favIconLinkBuf bytes.Buffer
templateVals := &struct {
FavIconUrl string
FavIconURL string
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This attribute is already being referenced by the updated name in the favIconLinkTemplate.

Copy link
Collaborator

@ojarjur ojarjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

I really appreciate you going out of your way to help improve the project's health.

@ojarjur ojarjur merged commit ed3e784 into google:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix golint errors

2 participants