Add std namespace to string to fix build#128
Closed
GMNGeoffrey wants to merge 1 commit intomasterfrom
Closed
Conversation
stellaraccident
pushed a commit
that referenced
this pull request
Sep 24, 2023
This uses a GCS bucket as a remote cache partitioned by docker image name and digest. This can be used for other builds as well using the same process. Speedups here are not spectacular, but it helps a bit. Tested: https://github.com/openxla/openxla-pjrt-plugin/actions/workflows/build_packages.yml Run 1 was writing the cache only and run 2 was with caching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are currently unprefixed which fails with bazel build.
With this change
$ bazel build -- //... -//integrations/tensorflow/e2e:simple_arithmetic_test
passes (exclude is for the failures in #127)