Turn on asserts by default in bazel build#1664
Closed
GMNGeoffrey wants to merge 2 commits intoiree-org:masterfrom
Closed
Turn on asserts by default in bazel build#1664GMNGeoffrey wants to merge 2 commits intoiree-org:masterfrom
GMNGeoffrey wants to merge 2 commits intoiree-org:masterfrom
Conversation
Contributor
Author
|
Rebased this a bit behind HEAD, since that's currently broken. @antiagainst going to let you decide when you want this to go in, since it might affect your current build copping |
Contributor
Author
|
Ping on this :-) |
benvanik
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are generally useful. At some point we might want to tweak the defaults or add more build configs, but if we're going to leave opt the default, then opt + asserts makes sense.
We've had issues that would've been diagnosed faster with asserts (e.g. #1620)