Fix Bazel and CMake build after LLVM integration #1672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLIR Linalg now adopts a two-level TableGen flow: some Linalg op's TableGen definition are first generated by a dedicated TableGen backend into `LinalgNamedStructuredOps.td` and then that file is TableGen'ed into C++ code. The path needs to be updated to let TableGen find the generated intermediate TD files.
GMNGeoffrey
approved these changes
Apr 25, 2020
antiagainst
changed the title
GMNGeoffrey
approved these changes
Apr 25, 2020
build_tools/cmake/iree_copts.cmake
Outdated
| ${PROJECT_SOURCE_DIR}/third_party/llvm-project/llvm/include | ||
| ${PROJECT_BINARY_DIR}/third_party/llvm-project/llvm/include | ||
| ${PROJECT_SOURCE_DIR}/third_party/llvm-project/mlir/include | ||
| ${PROJECT_BINARY_DIR}/third_party/llvm-project/mlir/include |
Contributor
There was a problem hiding this comment.
Looks like this is already listed right above?
Contributor
There was a problem hiding this comment.
Suggested change
| ${PROJECT_BINARY_DIR}/third_party/llvm-project/mlir/include |
GMNGeoffrey
approved these changes
Apr 25, 2020
build_tools/cmake/iree_copts.cmake
Outdated
| ${PROJECT_SOURCE_DIR}/third_party/llvm-project/llvm/include | ||
| ${PROJECT_BINARY_DIR}/third_party/llvm-project/llvm/include | ||
| ${PROJECT_SOURCE_DIR}/third_party/llvm-project/mlir/include | ||
| ${PROJECT_BINARY_DIR}/third_party/llvm-project/mlir/include |
Contributor
There was a problem hiding this comment.
Suggested change
| ${PROJECT_BINARY_DIR}/third_party/llvm-project/mlir/include |
Contributor
|
cmake build is still failing:
I'd be ok still submitting this since it's at least a step in the right direction and I can pick it up on Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated LLVM and TensorFlow SHA and fixed build configuration.
MLIR Linalg now adopts a two-level generation flow: some Linalg op's
op definitions are first generated by a dedicated TableGen backend into
LinalgNamedStructuredOps.tdand then that file is TableGen'ed intoC++ code. The include path needs to be updated to let TableGen find the
generated intermediate TD files.