Skip to content

Merging early work on Tracy feature branch.#1936

Closed
benvanik wants to merge 7 commits intomasterfrom
benvanik-tracy
Closed

Merging early work on Tracy feature branch.#1936
benvanik wants to merge 7 commits intomasterfrom
benvanik-tracy

Conversation

@benvanik
Copy link
Copy Markdown
Collaborator

@benvanik benvanik commented May 15, 2020

This replaces WTF with Tracy, which can be enabled in cmake builds with IREE_ENABLE_RUNTIME_TRACING. Bazel support will come soonish. This initial commit provides a full C API for Tracy, C++ shims for the existing IREE_TRACE_SCOPE0 macro (what's mostly used in the codebase today), and allocation tracking.

This has the side effect of removing another ALWAYSLINK library. Yay!

Progress on #1886; C API is in but still need to finish the C++ API before calling this done. Vulkan tracing will be added separately with #1937 as that requires more work.

Fixes #1480.

image

@benvanik benvanik added enhancement ➕ New feature or request runtime Relating to the IREE runtime library performance ⚡ Performance/optimization related work across the compiler and runtime labels May 15, 2020
@benvanik benvanik added this to the 2020Q2 Core milestone May 15, 2020
benvanik added 2 commits May 14, 2020 20:57
Future changes will enhance the C++ API and enable more features like
mutex tracking.
@benvanik benvanik marked this pull request as ready for review May 15, 2020 04:06
@benvanik benvanik requested a review from ScottTodd May 15, 2020 04:06
@benvanik benvanik changed the title Merging Tracy feature branch. Merging early work on Tracy feature branch. May 15, 2020
Comment thread iree/base/tracing.h Outdated
Comment thread iree/base/tracing.h
Comment thread iree/base/tracing.h Outdated
benvanik added 3 commits May 15, 2020 12:11
This avoids extraneous allocations in the VMLA command processor that were
causing very noisy traces. Future work on #1172 may make this redundant
but it's a good test of the Tracy integration.
Fixes #1942.
Reduces our memory consumption/allocations for VMLA executables by quite a
bit.
@benvanik benvanik deleted the benvanik-tracy branch June 16, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ➕ New feature or request performance ⚡ Performance/optimization related work across the compiler and runtime runtime Relating to the IREE runtime library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instrument allocations for tracy profiling

3 participants