Use LLVM Bazel BUILD files from google/llvm-bazel#2794
Merged
GMNGeoffrey merged 4 commits intoiree-org:mainfrom Oct 7, 2020
Merged
Use LLVM Bazel BUILD files from google/llvm-bazel#2794GMNGeoffrey merged 4 commits intoiree-org:mainfrom
GMNGeoffrey merged 4 commits intoiree-org:mainfrom
Conversation
GMNGeoffrey
force-pushed
the
llvm-overlay-build-files
branch
4 times, most recently
from
db7d554 to
436b603
Compare
GMNGeoffrey
force-pushed
the
llvm-overlay-build-files
branch
from
3e72fec to
300ffe7
Compare
GMNGeoffrey
force-pushed
the
llvm-overlay-build-files
branch
4 times, most recently
from
68759b3 to
411d0a5
Compare
GMNGeoffrey
force-pushed
the
llvm-overlay-build-files
branch
2 times, most recently
from
3660578 to
773c4cb
Compare
GMNGeoffrey
force-pushed
the
llvm-overlay-build-files
branch
from
c0414df to
e072fa3
Compare
GMNGeoffrey
changed the title
ScottTodd
reviewed
Oct 7, 2020
ScottTodd
approved these changes
Oct 7, 2020
Merged
GMNGeoffrey
added a commit
to GMNGeoffrey/iree
that referenced
this pull request
Oct 8, 2020
)" This reverts commit 17824b1. Breaks the Windows build with Bazel because I forgot that was a thing.
GMNGeoffrey
added a commit
to GMNGeoffrey/iree
that referenced
this pull request
Oct 8, 2020
)" This reverts commit 17824b1. Breaks the Windows build with Bazel because I forgot that was a thing.
GMNGeoffrey
added a commit
that referenced
this pull request
Oct 8, 2020
Merged
GMNGeoffrey
added a commit
that referenced
this pull request
Oct 27, 2020
Adopts build files from https://github.com/google/llvm-bazel. This is another attempt at #2794 now that google/llvm-bazel#60 added Windows support. These make our LLVM build independent of TensorFlow. Switching to them does slightly increase maintenance burden on our team because the TF team is not assisting in maintaining them. It is not a guarantee that llvm-bazel will already have a commit containing the up to date workflows. However, it does have an advertised tag for each LLVM commit that is the current best-effort for what builds, a workflow to automatically pull in new LLVM commits and a build pipeline that notifies me as soon as the build breaks (independent of any integration into Google source control). I've been mostly able to stay ahead of the integrates into Google source control. I will be expanding our build cop docs to cover more of the workflows here as I am buildcopping this week, but the general workflow is to run `./scripts/git/update_llvm_dependent_submodules.sh` in lieu of the update old `update_tf_submodule.sh` script. A GitHub action will also create those PRs automatically to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts build files from https://github.com/google/llvm-bazel.
These make our LLVM build independent of TensorFlow. Switching to them
does slightly increase maintenance burden on our team because the TF
team is not assisting in maintaining them. It is not a guarantee that
llvm-bazel will already have a commit containing the up to date
workflows. However, it does have an advertised tag for each LLVM commit
that is the current best-effort for what builds, a workflow to
automatically pull in new LLVM commits and a build pipeline that
notifies me as soon as the build breaks (independent of any integration
into Google source control).
For example google/llvm-bazel@0fc76899f74a
advances the build files ahead of what is currently supported by TF or
Google internally.
I will be expanding our build cop docs to cover more of the workflows
here as I am buildcopping this week, but the general workflow is to run
./scripts/git/update_llvm_dependent_submodules.shin lieu of theupdate old
update_tf_submodule.shscript. A GitHub action will alsocreate those PRs automatically to be merged.