Standardization pass through docs/ folder. #3597
Merged
ScottTodd merged 4 commits intoiree-org:mainfrom Oct 23, 2020
Merged
Conversation
benvanik
approved these changes
Oct 23, 2020
Contributor
|
I so badly want copy-paste that strips the |
GMNGeoffrey
reviewed
Oct 23, 2020
Comment on lines
+96
to
97
| # Use --config=asserts to enable assertions in IREE and LLVM. | ||
| build:asserts --compilation_mode=opt '--per_file_copt=iree|llvm@-UNDEBUG' |
Contributor
There was a problem hiding this comment.
Pretty sure @bjacob said this would create ODR violations and was bad
Member
Author
There was a problem hiding this comment.
We can follow up on that later, separate from this PR.
Contributor
There was a problem hiding this comment.
Yeah just noticed it :-)
Member
Author
Same... Discussed a bit on Discord. We have some options, none look super easy though. |
Merged
ScottTodd
added a commit
that referenced
this pull request
Oct 28, 2020
Knew there would be some issues in #3597 :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
../iree-build/instead of in-treebuild/.vmfbas VM module flatbuffer file extensions$-for LLVM flags and--for Abseil flags