Skip to content

Switch from bazel federation to direct deps #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GMNGeoffrey wants to merge 1 commit into from
Closed

Switch from bazel federation to direct deps #598

GMNGeoffrey wants to merge 1 commit into from

Conversation

@GMNGeoffrey
Copy link
Contributor

@GMNGeoffrey GMNGeoffrey commented Jan 29, 2020

With bazel federation we end up with version skew vs TFs rules_cc and they're starting to use some new stuff there.

This was preventing us from updating our TF and LLVM submodules. See #563

@GMNGeoffrey GMNGeoffrey deleted the tf-bazel-madness branch January 29, 2020 02:28
@GMNGeoffrey GMNGeoffrey mentioned this pull request Jan 29, 2020
Closed
copybara-service bot pushed a commit that referenced this pull request Jan 29, 2020
@GMNGeoffrey @copybara-github
Update TF & LLVM submodules
fdbac9b 
Now possible because of #598

$ git_scripts/update_tf_llvm_submodules.py --update_build_files=True

Closes #563

PiperOrigin-RevId: 292061076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stellaraccident stellaraccident stellaraccident approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GMNGeoffrey @stellaraccident @googlebot