Fix SRCS for ctests of iree tools#665
Closed
marbre wants to merge 1 commit intoiree-org:masterfrom
iml130:ctest-tools
Closed
Fix SRCS for ctests of iree tools#665marbre wants to merge 1 commit intoiree-org:masterfrom iml130:ctest-tools
marbre wants to merge 1 commit intoiree-org:masterfrom
iml130:ctest-tools
Conversation
Contributor
|
Ugh sorry. This is one of the issues with running the glob at conversion time. It's pretty easy to forget to rerun the converter if you didn't edit the build file. Having ctest run on presubmit would obviously help a lot, although it won't catch the case of adding a new test file. I think maybe we should switch to using the glob in cmake. |
GMNGeoffrey
approved these changes
Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #664