Add vm.bitcast ops for i32<->f32 and i64<->f64.#6664
Merged
ScottTodd merged 6 commits intoiree-org:mainfrom Aug 10, 2021
Merged
Add vm.bitcast ops for i32<->f32 and i64<->f64.#6664ScottTodd merged 6 commits intoiree-org:mainfrom
ScottTodd merged 6 commits intoiree-org:mainfrom
Conversation
ScottTodd
added
compiler/dialects
ScottTodd
added a commit
that referenced
this pull request
Aug 10, 2021
Working towards #6629 Depends on https://reviews.llvm.org/D105376 This requires no extra changes (beyond the dependent change in LLVM) to support splatting floating point _constants_. It will need a lowering from `std.bitcast` to `vm.bitcast` (#6664) for variable values.
benvanik
approved these changes
Aug 10, 2021
Member
Author
|
Presubmit passed but GitHub service degradation swallowed the completion signal. Merging manually. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards #6629
Also included a conversion for standard bitcast -> vm.bitcast.* ops.
See also https://reviews.llvm.org/D105376 for
std.bitcast, which has more details about endianness and includes some fold/canonicalization patterns. We have a more restrictive set of types to support here.