Skip to content

CMake: Improve support to build python bindings#695

Closed
marbre wants to merge 11 commits intoiree-org:masterfrom
iml130:cmake-python-bindings
Closed

CMake: Improve support to build python bindings#695
marbre wants to merge 11 commits intoiree-org:masterfrom
iml130:cmake-python-bindings

Conversation

@marbre
Copy link
Copy Markdown
Member

@marbre marbre commented Feb 6, 2020

  • Refactors iree_pybind_cc_library()
  • Adds iree_py_extension()
  • Updates and CMake targets for python bindings

The bindings are still not complete and currently only implements support for Linux.

Depends on #693 and #694. I will drop these commits and rebase if these patches get merged separately into master.

@marbre marbre changed the title CMake: CMake: Improve support to build python bindings Feb 6, 2020
@marbre
Copy link
Copy Markdown
Member Author

marbre commented Feb 6, 2020

I am gladly awaiting your feedback :) We might need an iteration before this can be merged, but I hope it is the right step to enable building the python bindings with CMake.

@stellaraccident
Copy link
Copy Markdown
Collaborator

Looking now...

@GMNGeoffrey
Copy link
Copy Markdown
Contributor

This broke the cmake build. To run kokoro on PRs and ensure we avoid a breakage, a repository collaborator needs to tag the PR with "kokoro:run"

@stellaraccident
Copy link
Copy Markdown
Collaborator

stellaraccident commented Feb 6, 2020 via email

@GMNGeoffrey
Copy link
Copy Markdown
Contributor

Yeah it's not a great situation :-/ They are somewhat authoritative, but we have to give them permission to run for contributions from outside the organization and nothing blocks on them on import. That's why I wanted to use GitHub required checks because it gives you a nice UI that indicates "hey this isn't ready to merge", but unfortunately it breaks copybara's ability to push directly to master.

@ScottTodd
Copy link
Copy Markdown
Member

CI build fix is at #700. We also discussed ways to make "this hasn't run presubmits yet" blocking or more obvious, but don't yet have a concrete plan.

copybara-service Bot pushed a commit that referenced this pull request Feb 7, 2020
(Broken since #695)

Closes #700

COPYBARA_INTEGRATE_REVIEW=#700 from ScottTodd:find-python cd4b13f
PiperOrigin-RevId: 293738813
@marbre
Copy link
Copy Markdown
Member Author

marbre commented Feb 7, 2020

My apologies. I probably have missed to do a full rebuild and only checked if the incremental build succeeds. Will send a patch to fix the bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants