Import renderdoc_app.h to iree/third_party, with build defs.#696
Closed
ScottTodd wants to merge 3 commits into
Closed
Import renderdoc_app.h to iree/third_party, with build defs.#696ScottTodd wants to merge 3 commits into
ScottTodd wants to merge 3 commits into
Conversation
Member
Author
|
Code style check is running clang-format on third_party/. That's not normally a problem since other files there are in submodules. I'll look into adding an exclusion, probably through |
GMNGeoffrey
approved these changes
Feb 6, 2020
ScottTodd
added a commit
that referenced
this pull request
Feb 7, 2020
Should make the style check pass on #696. Reference: https://clang.llvm.org/docs/ClangFormatStyleOptions.html
Includes are of the format (tested with Bazel and CMake): ``` #include "third_party/renderdoc_api/app/renderdoc_app.h" ```
ScottTodd
force-pushed
the
renderdoc-import
branch
from
d778065 to
495de2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #52. We can use RenderDoc without integrating with its API through
vulkan_inference_gui, but not throughiree-run-mlir. We need to explicitly start/stop capture through the API when only using Vulkan compute (no graphics). This PR imports the API header file so we can use it in future change.Includes are of the format (tested with Bazel and CMake):