Skip to content

Rename target iree_translate_library to iree_translate_main#903

Closed
marbre wants to merge 1 commit intoiree-org:masterfrom
iml130:translate_main_target
Closed

Rename target iree_translate_library to iree_translate_main#903
marbre wants to merge 1 commit intoiree-org:masterfrom
iml130:translate_main_target

Conversation

@marbre
Copy link
Copy Markdown
Member

@marbre marbre commented Mar 2, 2020

The target iree_translate_library includes a main function. Hence, renaming.

@marbre marbre requested a review from GMNGeoffrey March 2, 2020 09:41
@marbre
Copy link
Copy Markdown
Member Author

marbre commented Mar 2, 2020

Seems that the access granted to me by @stellaraccident allows to request reviews again and it is further sufficient to automatically trigger kokoro builds 🎉 😃

@GMNGeoffrey
Copy link
Copy Markdown
Contributor

Seems that the access granted to me by @stellaraccident allows to request reviews again and it is further sufficient to automatically trigger kokoro builds

Nice! I wasn't sure what the policy was there, but yeah this certainly makes everyone's life easier. Just don't go on a wild triaging spree :-P

@marbre
Copy link
Copy Markdown
Member Author

marbre commented Mar 3, 2020

Just don't go on a wild triaging spree :-P

No, I'm saving that fun for the local machines ;-)

Would you mind to add a ready to pull label on this PR (no rebasing required)? Technically, it seems that I could do so myself, but I don't know if this is intended or desired even though you approved my changes.

@GMNGeoffrey
Copy link
Copy Markdown
Contributor

Would you mind to add a ready to pull label on this PR (no rebasing required)? Technically, it seems that I could do so myself, but I don't know if this is intended or desired even though you approved my changes.

Done. Sorry I should've done that when I approved. But yeah there are some idiosyncrasies, so maybe hold off on adding "ready to pull" on things

@copybara-service copybara-service Bot closed this in 6d8b59b Mar 6, 2020
@marbre marbre deleted the translate_main_target branch June 29, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants