Skip warning about duplicate annotations if the values match. #1532
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
approved these changes
Nov 16, 2025
Collaborator
kevmoo
left a comment
kevmoo
left a comment
There was a problem hiding this comment.
Thanks! Want me to publish soonish?
Collaborator
Author
|
Publish sounds good to me, yes please, there are quite a few people interested in this it seems :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rrousselGit/freezed#1289
Freezed copies annotations onto generated code, which triggers the json_serializable warning.
Fix by skipping warning if the value matches.
I'm not 100% sure about the implementation, I did add a test, but please do check it makes sense :)