Skip to content

[fuzzer] Do not generate void expressions in sizeof #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2021
Merged

[fuzzer] Do not generate void expressions in sizeof #132

merged 2 commits into from
May 25, 2021

Conversation

@tonkosi
Copy link
Contributor

@tonkosi tonkosi commented May 25, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented May 25, 2021

Benchmark comparison for 4317381e (base) vs 8f7f4fea (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   +0.0153         +0.0152        142626        144808        142599        144765
BM/ArrayDereference                +0.0388         +0.0394        142789        148334        142695        148314
BM/ArraySubscript                  -0.0254         -0.0256        192621        187725        192569        187648
BM/TypeCasting                     +0.0054         +0.0047        479776        482357        479734        481988
BM/ParseInteger                    +0.1041         +0.1040        198163        218783        198145        218758

@tonkosi tonkosi requested a review from werat May 25, 2021 13:18
werat
werat reviewed May 25, 2021
View reviewed changes
tools/fuzzer/constraints.h Outdated
}

static TypeConstraints all_non_void() {
TypeConstraints retval = all();
Copy link
Member

@werat werat May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there cases when all() actually makes sense? All expressions should return something, so we never want void, right?

Copy link
Contributor Author

@tonkosi tonkosi May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. Completely replaced all() with all_non_void().

@github-actions
Copy link

github-actions bot commented May 25, 2021

Benchmark comparison for 4317381e (base) vs 5898e3f0 (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   +0.0163         +0.0159        157149        159715        157120        159623
BM/ArrayDereference                +0.0014         +0.0021        172968        173207        172825        173190
BM/ArraySubscript                  +0.0132         +0.0133        209615        212372        209558        212349
BM/TypeCasting                     +0.0197         +0.0190        475440        484797        475371        484426
BM/ParseInteger                    +0.0097         +0.0096        209651        211679        209623        211645

@werat werat merged commit cc5958e into master May 25, 2021
@werat werat deleted the tonkosi/fuzzer-avoid-sizeof-void branch May 25, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@werat werat werat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonkosi @werat