Skip to content

[fuzzer] Fix Linux specific issues #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 18, 2021
Merged

[fuzzer] Fix Linux specific issues #142

merged 4 commits into from
Jun 18, 2021

Conversation

@tonkosi
Copy link
Contributor

@tonkosi tonkosi commented Jun 18, 2021

Fix issues causing false mismatches on Linux (assuming LLDB 12):

  • Use -static to build test binaries (this prevents picking up wrong __log2 from libm.so),
  • Add option to disable long double,
  • Take into consideration that lldb-eval doesn't support address-of elision in member-of expressions.

@github-actions
Copy link

github-actions bot commented Jun 18, 2021

Benchmark comparison for d96cefe5 (base) vs f8c8ae8b (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   +0.0434         +0.0436        147150        153538        147072        153490
BM/ArrayDereference                +0.0115         +0.0112        163474        165357        163454        165280
BM/ArraySubscript                  +0.0451         +0.0448        194870        203657        194849        203573
BM/TypeCasting                     +0.0364         +0.0363        456037        472639        455987        472544
BM/ParseInteger                    +0.0251         +0.0251        199619        204638        199603        204611

@github-actions
Copy link

github-actions bot commented Jun 18, 2021

Benchmark comparison for d96cefe5 (base) vs 10347ed2 (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   -0.0011         -0.0009        137319        137168        137245        137122
BM/ArrayDereference                +0.0043         +0.0049        144418        145042        144314        145019
BM/ArraySubscript                  +0.0097         +0.0097        187769        189600        187753        189573
BM/TypeCasting                     -0.0099         -0.0094        490856        485973        490543        485910
BM/ParseInteger                    +0.0007         +0.0007        202891        203036        202872        203014

@tonkosi tonkosi requested a review from werat June 18, 2021 10:08
werat
werat reviewed Jun 18, 2021
View reviewed changes
testdata/rules.bzl
),
"//conditions:default": build_cmd.format(
platform_opts = "-lstdc++",
platform_opts = "-lstdc++ -static",
Copy link
Member

@werat werat Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here about why -static

@github-actions
Copy link

github-actions bot commented Jun 18, 2021

Benchmark comparison for d96cefe5 (base) vs 4d8e9c90 (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   +0.0063         +0.0050        161363        162382        161339        162140
BM/ArrayDereference                -0.0506         -0.0500        175990        167090        175880        167080
BM/ArraySubscript                  -0.0040         -0.0040        214304        213454        214284        213437
BM/TypeCasting                     -0.0375         -0.0378        510642        491517        510601        491309
BM/ParseInteger                    -0.0429         -0.0429        226037        216350        226014        216326

@github-actions
Copy link

github-actions bot commented Jun 18, 2021

Benchmark comparison for d96cefe5 (base) vs 1a1a1fc7 (PR)

Benchmark                             Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------
BM/AddTwoNumbers                   -0.0005         -0.0005        136309        136237        136279        136210
BM/ArrayDereference                -0.0004         -0.0007        143080        143019        143060        142964
BM/ArraySubscript                  +0.0128         +0.0128        186935        189319        186916        189305
BM/TypeCasting                     -0.0051         -0.0048        485072        482593        484896        482563
BM/ParseInteger                    -0.0087         -0.0092        202943        201176        202872        201006

@werat werat merged commit 87860f4 into master Jun 18, 2021
@werat werat deleted the tonkosi/fuzzer-linux-issues branch June 18, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@werat werat werat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonkosi @werat