Fixes required for targeting wasm32 #199
Conversation
pfaffe
changed the title
| #ifndef __EMSCRIPTEN__ | ||
| EXPECT_THAT(Scope("bf").Eval("a"), IsEqual("1023")); | ||
| EXPECT_THAT(Scope("bf").Eval("b"), IsEqual("9")); | ||
| EXPECT_THAT(Scope("bf").Eval("c"), IsEqual("false")); | ||
| EXPECT_THAT(Scope("bf").Eval("d"), IsEqual("true")); | ||
| #endif |
There was a problem hiding this comment.
What's wrong with these? Is scoped evaluation not supported for wasm32?
| #ifndef __EMSCRIPTEN__ | ||
| TEST_F(EvalTest, TestDereferencedType) { |
There was a problem hiding this comment.
What's wrong with this test? It seems to me this should work for wasm32 too...
There was a problem hiding this comment.
It's the unconditional comparison with lldb's output here. wasm32 can't run lldb, so we can't do this comparison.
| #ifndef __EMSCRIPTEN__ | ||
| TEST_F(EvalTest, TestCompositeAssignmentAdd) { |
There was a problem hiding this comment.
Have you considered doing something like this when disabling the whole test?
#ifdef __EMSCRIPTEN__
// Doesn't work on wasm32 because of X
GTEST_SKIP() << "not supported on wasm32";
#else
There was a problem hiding this comment.
I did, but ifdef'ing out the entire test simplifies the wasm wrapper, so that it doesn't have to provide noop implementations of things like EvalWithContext() or Scope(). This seemed cleaner than implementing methods that aren't supposed to be called.
2 participants
Drive-by: Fix pointer comparison on 32bit targets