Add group functions library #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/ml-compiler-opt
that referenced
this pull request
May 16, 2025
This patch adds a library and associated unit tests for grouping functions emitted from the extract_functions script for more efficient compilation. Pull Request: google#507
boomanaiden154
added a commit
to boomanaiden154/ml-compiler-opt
that referenced
this pull request
May 16, 2025
This patch adds a library and associated unit tests for grouping functions emitted from the extract_functions script for more efficient compilation. Pull Request: google#507
Created using spr 1.3.4 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/ml-compiler-opt
that referenced
this pull request
May 16, 2025
This patch adds a library and associated unit tests for grouping functions emitted from the extract_functions script for more efficient compilation. Pull Request: google#507
mtrofin
reviewed
May 16, 2025
| function_corpus = corpus.Corpus( | ||
| data_path=function_folder, | ||
| delete_flags=delete_flags, | ||
| construct_cmd_for_compilation=False) |
There was a problem hiding this comment.
Not sure what you're commenting on here. function_corpus is used shortly below. We need construct_cmd_for_compilation to be set to False to avoid getting an extra -x ir {} stuck in the command line from the corpus tooling.
mtrofin
approved these changes
May 20, 2025
boomanaiden154
added a commit
to boomanaiden154/ml-compiler-opt
that referenced
this pull request
May 20, 2025
This patch adds a library and associated unit tests for grouping functions emitted from the extract_functions script for more efficient compilation. Pull Request: google#507
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/ml-compiler-opt
that referenced
this pull request
May 20, 2025
This patch adds a library and associated unit tests for grouping functions emitted from the extract_functions script for more efficient compilation. Pull Request: google#507
Created using spr 1.3.4 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/ml-compiler-opt
that referenced
this pull request
May 20, 2025
This patch adds a library and associated unit tests for grouping functions emitted from the extract_functions script for more efficient compilation. Pull Request: google#507
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
boomanaiden154
changed the base branch from
spr/boomanaiden154/main.add-group-functions-library
to
main
svkeerthy
pushed a commit
that referenced
this pull request
May 22, 2025
This patch adds a library and associated unit tests for grouping functions emitted from the extract_functions script for more efficient compilation. Reviewers: svkeerthy, mtrofin Reviewed By: mtrofin Pull Request: #507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a library and associated unit tests for grouping
functions emitted from the extract_functions script for more efficient
compilation.