Restore best model test functionality #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6
boomanaiden154
added a commit
to boomanaiden154/ml-compiler-opt
that referenced
this pull request
Jul 23, 2025
Some of the tests around the "save best model" functionality were changed up in 6cf15b3 as it touched SamplingBlackboxEvaluator which is used in the tests in a way that made them not work. This patch restores the functionality by changing up how the tests work a bit so they test what they are intended to. Pull Request: google#521
boomanaiden154
deleted the
users/boomanaiden154/restore-best-model-test-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests around the "save best model" functionality were
changed up in 6cf15b3 as it touched
SamplingBlackboxEvaluator which is used in the tests in a way that made
them not work. This patch restores the functionality by changing up how
the tests work a bit so they test what they are intended to.