Add no_delay and no_cork flags to help tcp_stream send small packets #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylestanfield
force-pushed
the
tcpSmallPackets
branch
from
0f4987b to
6cb4af0
Compare
Contributor
Author
|
Thanks for your comments. Fixed all the spacing issues. Had the wrong settings in my .vimrc :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add no_delay and no_cork options to help allow tcp_stream to send small packets
no_delay -- disable Nagle's algorithm on data sockets
no_cork -- If set, do not use MSG_MORE flag when sending with tcp_stream
MSG_MORE logic in tcp_stream was not upstreamed yet so I added the line to set the flag if no_cork is not used.
When used together, tcp_stream won't coalesce small writes into larger packets.