Remove redundant callback logic for --logtostderr enablement. #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the logging_init function call we are already setting log_file to stderr when --logtostderr file is enabled. So, now there is no need of callback function that need to be registered like what logtostderr is currently doing. Tested: Ran make and tests for all type of workload with --logtostderr flag and error is getting logged to the console(stderr) correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the logging_init function call we are already setting log_file to stderr when --logtostderr file is enabled. So, now there is no need of callback function that need to be registered like what logtostderr is currently doing.
Tested: Ran make and tests for all type of workload with --logtostderr flag and error is getting logged to the console(stderr) correctly.