Sync a few small CLs: #1060
Merged
Sync a few small CLs: #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cl/660721933: moves some proto3 parsing functions to utils to allow reusing internally in a library when parsing an internal format. - cl/646759129: Update `CodedBufferReader` default depth limit to 100, to be consistent with the C++ and Java implementations. - cl/704280814: Update `CodedBufferReader` default size limit to max 32-bit signed integer to be consistent with the C++, Java, Objective-C implementations. - Also a minor change, not a CL: Type casts in `coded_buffer_writer.dart` was updated in this repo probably accidentally, as we never want to type cast with `as` in this repo. Revert it to the internal version which uses implicit casts. With this, about half of the protobuf files become identical with the internal version.
sigurdm
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cl/660721933: moves some proto3 parsing functions to utils to allow reusing internally in a library when parsing an internal format.
cl/646759129: Update
CodedBufferReaderdefault depth limit to 100, to be consistent with the C++ and Java implementations.cl/704280814: Update
CodedBufferReaderdefault size limit to max 32-bit signed integer to be consistent with the C++, Java, Objective-C implementations.Also a minor change, not a CL: Type casts in
coded_buffer_writer.dartwas updated in this repo probably accidentally, as we never want to type cast withasin this repo. Revert it to the internal version which uses implicit casts.With this, about half of the protobuf files become identical with the internal version.