-
Notifications
You must be signed in to change notification settings - Fork 197
Add well-known type support #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
|
So with this change any breaking change in Not sure if this is a big deal in practice, but for example when we merge all of the generated files into one in the future it'll require a major version bump in |
protoc_plugin/pubspec.yaml
Outdated
| dart_style: ^3.0.0 | ||
| fixnum: ^1.0.0 | ||
| path: ^1.8.0 | ||
| protobuf: ^5.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| protobuf: ^5.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would make the solver help out and avoid mismatches.
sigurdm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would even better if we could add a dart_package option to the protos - but this is clearly an improvement over the status quo.
Really nice.
I agree, but that's also more work, and it needs to be done by the C++ protobuf team. If we do it in the future it should be a backwards compatible change: the descriptors (those in the json files) in the protobuf package will get the new options (once we update the wkt protos in the repo, re-generate the compiled files, publish). This should be backwards compatible unless your code is handling the non-existent |
Add generated Dart for the well-known protos to the package.
Special case
google/protobuf/...imports in the plugin to generate importsto the libraries in the protobuf package.
Note:
protocalready special cases these imports, you don't have to specifypaths to them with
-I....With this change you also don't have to manually compile them to Dart
classes.
Fixes #1073.
Fixes #817.
Fixes #780.
Fixes #483.
Changes to test files to use internal wkt protos: cl/831301744 (merged)
Output configuration change tested in: cl/831310910