Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Conversation

maruel
Copy link
Contributor

@maruel maruel commented Mar 2, 2016

Change imports to always be relative to the package, e.g. "from adb import ..."

make_tools.py creates standalone, easy to distribute executables meant to be
used in a continuous integration system via various CPU architecture where
having interpreted code is valuable.

Make progressbar optional so both adb.zip and fastboot.zip do not have any hard
dependency except python-libusb.

make_tools.py Outdated
The same way one would have run:
python adb_debug.py devices

The zips can be transfered on other computers (and other CPU architectures) for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transferred to other*

@fahhem
Copy link
Contributor

fahhem commented Mar 2, 2016

There are merge conflicts, but otherwise LGTM

Change imports to always be relative to the package, e.g. "from adb import ..."

make_tools.py creates standalone, easy to distribute executables meant to be
used in a continuous integration system via various CPU architecture where
having interpreted code is valuable.

Make progressbar optional so both adb.zip and fastboot.zip do not have any hard
dependency except python-libusb.
@maruel maruel force-pushed the flags_tools branch 3 times, most recently from bfc5414 to 7546aab Compare March 2, 2016 04:17
@maruel
Copy link
Contributor Author

maruel commented Mar 2, 2016

Rebased. Thanks for the README.rst -> README.md rename. I should have left out of this PR but doing it upfront is even better.

@fahhem
Copy link
Contributor

fahhem commented Mar 2, 2016

Hmm, we should include the output of make_tools.py into the releases, I wonder if there's a way to do that automatically?

fahhem added a commit that referenced this pull request Mar 2, 2016
Add make_tools.py to generate adb.zip and fastboot.zip.
@fahhem fahhem merged commit 96bf720 into google:master Mar 2, 2016
@maruel
Copy link
Contributor Author

maruel commented Mar 2, 2016

You mean on github? Good question. I have never done that but I doesn't look too hard; https://developer.github.com/v3/repos/releases/#create-a-release

@fahhem
Copy link
Contributor

fahhem commented Mar 2, 2016

Ah, I see, you upload arbitrary binary files for the release. Maybe there's tooling, or I'll have to remember to run make_tools.py before each release?

@maruel
Copy link
Contributor Author

maruel commented Mar 2, 2016

You could use it when you create tags, https://docs.travis-ci.com/user/deployment/releases/

@fahhem
Copy link
Contributor

fahhem commented Mar 2, 2016

Ah, there we go! Thanks! A travis config to run make_tools.py in before_deploy and then upload the files on tag creation will be the plan then, I'll make an issue now

@maruel maruel deleted the flags_tools branch March 5, 2016 02:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants