Fixed "full hairy example" of formatting control string in Common Lisp style guide #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example produced wrong results:
```
CL-USER> (format nil "Items:~#[ none~; ~S~; ~S and ~S~:;~@{~#[~; and~] ~S~^ ,~}~]." :foo :bar :baz :kadabr)
"Items: :FOO , :BAR , :BAZ , and :KADABR."
```
With this fix, it uses commas correctly:
```
CL-USER> (format nil "Items: ~#[ none~; ~S~; ~S and ~S~:;~@{~S~^~#[~; and ~:;, ~]~}~]." :foo :bar :baz :kadabr)
"Items: :FOO, :BAR, :BAZ and :KADABR."
```
svetlyak40wt
changed the title
|
Ok |
Contributor
Author
|
@kevinlindkvist is it possible to merge this pull? |
Contributor
Author
|
Guys, are there any chances this pull will be merged? |
Contributor
Author
|
@gfavors21 please, merge the pull request. |
Contributor
Author
|
What does this mean "cla:yes? |
Contributor
Author
|
Guys, please, merge this pull! |
Contributor
Author
|
@tonyruscoe Tony, could you please merge this pull-request? |
Member
|
Apologies for the silence here. I’m following up with the owners of the Common Lisp Style Guide at Google, since it looks like this file is out of sync with our internal version. Thanks for your patience! |
Contributor
Author
|
Great! Thank you! |
Contributor
Author
|
Thank you, @sfreilich! |
zasgar
referenced
this pull request
in pixie-io/cpplint
Sep 2, 2021
Fixed "full hairy example" of formatting control string in Common Lisp style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example produced wrong results:
With this fix, it uses commas correctly: