Skip to content

Reduce custom error allocation#70

Merged
pborman merged 1 commit intogoogle:masterfrom
johejo:zero_alloc_for_custom_error
Jan 4, 2021
Merged

Reduce custom error allocation#70
pborman merged 1 commit intogoogle:masterfrom
johejo:zero_alloc_for_custom_error

Conversation

@johejo
Copy link
Copy Markdown
Contributor

@johejo johejo commented Jan 4, 2021

Zero allocation by using non-pointer error.

related #69

name               old time/op    new time/op    delta
ParseBadLength-16    15.4ns ± 0%     3.5ns ± 0%   ~     (p=1.000 n=1+1)

name               old alloc/op   new alloc/op   delta
ParseBadLength-16     8.00B ± 0%     0.00B        ~     (p=1.000 n=1+1)

name               old allocs/op  new allocs/op  delta
ParseBadLength-16      1.00 ± 0%      0.00        ~     (p=1.000 n=1+1)

Zero allocation by using non-pointer error.

related google#69

name               old time/op    new time/op    delta
ParseBadLength-16    15.4ns ± 0%     3.5ns ± 0%   ~     (p=1.000 n=1+1)

name               old alloc/op   new alloc/op   delta
ParseBadLength-16     8.00B ± 0%     0.00B        ~     (p=1.000 n=1+1)

name               old allocs/op  new allocs/op  delta
ParseBadLength-16      1.00 ± 0%      0.00        ~     (p=1.000 n=1+1)
@pborman
Copy link
Copy Markdown
Contributor

pborman commented Jan 4, 2021

Thanks, this is a good optimization.

@pborman pborman merged commit 85223fa into google:master Jan 4, 2021
@taadis
Copy link
Copy Markdown

taadis commented Jan 5, 2021

why?

tkarrass pushed a commit to tkarrass/uuid that referenced this pull request Sep 11, 2024
Zero allocation by using non-pointer error.

related google#69

name               old time/op    new time/op    delta
ParseBadLength-16    15.4ns ± 0%     3.5ns ± 0%   ~     (p=1.000 n=1+1)

name               old alloc/op   new alloc/op   delta
ParseBadLength-16     8.00B ± 0%     0.00B        ~     (p=1.000 n=1+1)

name               old allocs/op  new allocs/op  delta
ParseBadLength-16      1.00 ± 0%      0.00        ~     (p=1.000 n=1+1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants