hash.go hash error covered and linter error fixed#71
Merged
pborman merged 2 commits intogoogle:masterfrom Jan 15, 2021
yusufpapurcu:patch-1
Merged
hash.go hash error covered and linter error fixed#71pborman merged 2 commits intogoogle:masterfrom yusufpapurcu:patch-1
pborman merged 2 commits intogoogle:masterfrom
yusufpapurcu:patch-1
Conversation
Error covered without change function definition
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
pborman
suggested changes
Jan 8, 2021
Contributor
pborman
left a comment
There was a problem hiding this comment.
These error checks are unnecessary:
type Hash interface {
// Write (via the embedded io.Writer interface) adds more data to the running hash.
// It never returns an error.
io.Writer
Contributor
Author
|
So we need to add |
Contributor
|
Thank you. FYI, the other option is just saying |
tkarrass
pushed a commit
to tkarrass/uuid
that referenced
this pull request
Sep 11, 2024
* hash.go hash error covered and linter error fixed Error covered without change function definition * Update hash.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error covered without change function definition