Skip to content

Add NewString Func#73

Merged
pborman merged 2 commits intogoogle:masterfrom
jackterm:add-new-str-func
Jan 22, 2021
Merged

Add NewString Func#73
pborman merged 2 commits intogoogle:masterfrom
jackterm:add-new-str-func

Conversation

@jackterm
Copy link
Copy Markdown
Contributor

@jackterm jackterm commented Jan 22, 2021

  • Adds NewString() func, which encapsulates the more verbose New().String()
  • We use New().String() for testing, and it feels ugly. Rather than adding a wrapper around google/uuid, figured it makes sense to add the utility method to the root package

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jan 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jackterm
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@pborman pborman merged commit bfb86fa into google:master Jan 22, 2021
@pborman
Copy link
Copy Markdown
Contributor

pborman commented Jan 22, 2021

Thank you, this looks good and is a nice addition (it is actually the equivalent of gitHub.com/pborman/uuid.New() which was the original package (but now is implemented in terms of this package). I think that was one thing people missed.

tkarrass pushed a commit to tkarrass/uuid that referenced this pull request Sep 11, 2024
* added utility func

* updated docs & function call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants