fix: neovim vroom tests #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Four problems that were preventing the vroom tests from running on neovim: - The vroom version was too old, see google/vroom#104 - The maktaba version was too old, see google/vim-maktaba#172. I considered constraining this to neovim but it applies to recent vim as well (the version of vim in travis/xenial is quite old) and the extra version checking seems pointless. - The get-pip.py invocation was outdated. - For some reason neovim pauses more often with "Hit ENTER" messages. Perhaps newer vim would too. In any case, increasing the cmdheight solves the problem without needing to sprinkle :silent everywhere.
dbarnett
suggested changes
Dec 30, 2019
Contributor
dbarnett
left a comment
dbarnett
left a comment
There was a problem hiding this comment.
Thanks!
The neovim issue is google/vroom#83; they suggested a workaround of always sending ENTER when it might happen, but no good solution atm. Setting cmdheight is a nice trick, and might work on some of the others that were stuck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four problems that were preventing the vroom tests from running on
neovim:
The vroom version was too old, see
Fix neovim support vroom#104
The maktaba version was too old, see
maktaba#ensure#IsCallable and maktaba#value#IsEnum broken in Vim >= 7.4.1875, breaking Maktaba entirely vim-maktaba#172. I considered
constraining this to neovim but it applies to recent vim as well (the
version of vim in travis/xenial is quite old) and the extra version
checking seems pointless.
The get-pip.py invocation was outdated.
For some reason neovim pauses more often with "Hit ENTER" messages.
Perhaps newer vim would too. In any case, increasing the cmdheight
solves the problem without needing to sprinkle :silent everywhere.