Add isort for python import sorting #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you sign the Contributor License Agreement at https://cla.developers.google.com/? Sorry for the extra step, but Google wants to make sure all the legal risks are covered. |
Contributor
Author
|
Done, please rescan. |
Contributor
|
Thanks, good now! Will review changes in a bit. |
dbarnett
approved these changes
Dec 24, 2021
|
I shouldn't have closed my PR lmao |
Contributor
Author
|
I had not even seen it. Yours even has unit tests! I wonder whether your tests work with my implementation. |
I have no idea, have not tested them, just went off the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.