Don't call clang-format on empty buffer #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think you want Vroom is easily confused by splitting stateful commands across lines and even more confused by trying to catch errors in vimscript. |
dbarnett
suggested changes
Jan 20, 2022
ezzieyguywuf
force-pushed
the
master
branch
2 times, most recently
from
b7bf8bc to
e9f25ff
Compare
dbarnett
suggested changes
Jan 22, 2022
Contributor
dbarnett
left a comment
dbarnett
left a comment
There was a problem hiding this comment.
Looks good, one question about the clang-format invocation and one minor question in the vroom test.
Signed-off-by: Wolfgang E. Sanyer <WolfgangSanyer@Google.com>
dbarnett
reviewed
Feb 8, 2022
dbarnett
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did my best to generate a unit test that duplicates the bug, however I've stared
it at so long I'm going cross-eyed and I still cannot figure out a good way to do this.
My problem is I'm not sure how to check the output of
:FormatCode clang-formatforan error (or lack thereof). I tried using a
try-catchbut was unsure how todo this with vroom while still intercepting the system calls to provide a mocked
response.
Any help on figuring out a good unit test for this would be greatly appreciated.