Add --warnings flag for buildifier #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarnett
reviewed
Jul 16, 2022
| endif | ||
| let l:warnings_flag = s:plugin.Flag('buildifier_warnings') | ||
| if l:warnings_flag != "" | ||
| let l:cmd += ["--warnings=" . l:warnings_flag] |
Contributor
There was a problem hiding this comment.
I think if there are spaces in the flag value this will do the right thing since maktaba#syscall will do escaping, but could you verify?
Contributor
Author
There was a problem hiding this comment.
I'm not sure what you mean by 'the right thing', since spaces are not allowed in this flag. I could add a check and throw an error in that case, but then the question arises; why not check all other invalid characters as well?
I tried this:
Glaive codefmt buildifier_lint_mode='' buildifier_warnings='+unsorted-dict-items --lint=invalid'
and it just ignores the invalid flag - so I guess it must be inserting a backslash before the space and therefore not passing --line=invalid as a separate argument. If we later add a flag that is allowed to contain spaces, this should do the right thing.
dbarnett
reviewed
Jul 16, 2022
In your vimrc you can do e.g. call glaive#Install() Glaive codefmt buildifier_lint_mode='fix' Glaive codefmt buildifier_warnings='-module-docstring,+unsorted-dict-items' to get buildifier to ignore missing module docstrings but sort dictionaries automatically. The default behaviour is unchanged.
Contributor
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In your vimrc you can do e.g.
to get buildifier to ignore missing module docstrings but sort
dictionaries automatically. The default behaviour is unchanged.