Stop passing -sort-includes to clang-format #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-sort-includes was added in LLVM r248367, and is enabled-by-default as of r253202, both of which will presumably be included in LLVM 3.8 (which hasn't yet been released). Removing this flag allows :FormatCode to work with development clang-format versions in the range [r242222, r248367), which identify as 3.8.0 but don't support -sort-includes. This effectively reverts cb42d28. Fixes google#64.
|
LGTM. |
malcolmr
added a commit
that referenced
this pull request
Dec 23, 2015
Stop passing -sort-includes to clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-sort-includeswas added in LLVM r248367, and is enabled-by-default as of r253202, both of which will presumably be included in LLVM 3.8 (which hasn't yet been released).Removing this flag allows
:FormatCodeto work with development clang-format versions in the range [r242222, r248367), which identify as 3.8.0 but don't support-sort-includes.This effectively reverts cb42d28. Fixes #64.